Remove offscreen image request downgrading feature flag (#57226)#57226
Open
sammy-SC wants to merge 1 commit into
Open
Remove offscreen image request downgrading feature flag (#57226)#57226sammy-SC wants to merge 1 commit into
sammy-SC wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@sammy-SC has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108411690. |
Summary: Pull Request resolved: react#57226 This removes the experimental `enableImageRequestDowngradingForNonVisibleImages` feature flag and backs out the behavior it gated. When enabled, `ImageShadowNode` downgraded image requests to prefetch priority for images that layout determined did not intersect the viewport — threading an `ImageRequestPriority` through `ImageRequestParams` and the Apple image managers, and propagating per-node viewport frames during Yoga layout via `experimental_layoutOrigin`/`experimental_layoutFrame` on `LayoutContext`. The flag defaulted to off and was never enabled in a release, and the gated behavior did not deliver the expected improvement, so the feature is removed entirely: `<Image>` once again always requests at immediate priority. This deletes the feature flag, the `ImageRequestPriority` enum and the `ImageRequestParams::priority` field, the priority parameter on `RCTImageManager`/`RCTSyncImageManager`/`RCTImageManagerProtocol`, the `experimental_layout*` `LayoutContext` fields and their Yoga propagation, the iOS request-priority debug overlay, and the associated Fantom test scaffolding. The generated feature-flag sources and the C++ API snapshots are regenerated accordingly. Changelog: [Internal] Reviewed By: javache Differential Revision: D108411690
meta-codesync
Bot
changed the title
sammy-SC
force-pushed
the
export-D108411690
branch
from
c62f78e to
25a7eda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This removes the experimental
enableImageRequestDowngradingForNonVisibleImagesfeature flag and backs out the behavior it gated. When enabled,ImageShadowNodedowngraded image requests to prefetch priority for images that layout determined did not intersect the viewport — threading anImageRequestPrioritythroughImageRequestParamsand the Apple image managers, and propagating per-node viewport frames during Yoga layout viaexperimental_layoutOrigin/experimental_layoutFrameonLayoutContext.The flag defaulted to off and was never enabled in a release, and the gated behavior did not deliver the expected improvement, so the feature is removed entirely:
<Image>once again always requests at immediate priority. This deletes the feature flag, theImageRequestPriorityenum and theImageRequestParams::priorityfield, the priority parameter onRCTImageManager/RCTSyncImageManager/RCTImageManagerProtocol, theexperimental_layout*LayoutContextfields and their Yoga propagation, the iOS request-priority debug overlay, and the associated Fantom test scaffolding. The generated feature-flag sources and the C++ API snapshots are regenerated accordingly.Changelog: [Internal]
Reviewed By: javache
Differential Revision: D108411690